Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release assets for macos x64 and arm64 (M1) #519

Merged
merged 5 commits into from
Apr 17, 2023
Merged

ci: release assets for macos x64 and arm64 (M1) #519

merged 5 commits into from
Apr 17, 2023

Conversation

CyberHippo
Copy link
Contributor

Description

  • Fixes the release of macos package assets

The release workflow did not find any macos assets to upload:

🤔 Pattern 'dist/macos/asyncapi.pkg' does not match any files.
🤔 dist/macos/asyncapi.pkg not include valid file.

This was caused by oclif which is now supporting arm64 arch (See oclif/oclif#847). The macos assets are now ${name}-v${version}-${sha}-x64.pkg and ${name}-v${version}-${sha}-arm64.pkg:

Run ls -la dist/macos/
total 581912
drwxr-xr-x  4 runner  staff        128 Apr 13 11:33 .
drwxr-xr-x  4 runner  staff        128 Apr 13 11:33 ..
-rw-r--r--  1 runner  staff  148119971 Apr 13 11:33 asyncapi-v0.37.2-82ba8ff-arm64.pkg
-rw-r--r--  1 runner  staff  149812837 Apr 13 11:33 asyncapi-v0.37.2-82ba8ff-x64.pkg

@derberg We could use the glob pattern matching for the files of the Action softprops/action-gh-release@v1 instead of passing the full file name. What do you think ?

      - name: Update release
        uses: softprops/action-gh-release@v1
        with:
          files: dist/${{ matrix.dist_folder }}/*
          tag_name: v${{ steps.extractver.outputs.version }}
          token: ${{ secrets.GH_TOKEN }}

Related issue(s)
See also #501.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Apr 17, 2023

@CyberHippo

@derberg We could use the glob pattern matching for the files of the Action softprops/action-gh-release@v1 instead of passing the full file name. What do you think ?

can you open a separate issue for that topic. I think we in general need to come up with an idea on how to make sure we know earlier that these distros are failing on a release

derberg
derberg approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!!!

@derberg derberg changed the title chore(workflows): release assets for macos x64 and arm64 (M1) chore(ci): release assets for macos x64 and arm64 (M1) Apr 17, 2023
@derberg derberg changed the title chore(ci): release assets for macos x64 and arm64 (M1) ci: release assets for macos x64 and arm64 (M1) Apr 17, 2023
@derberg
Copy link
Member

derberg commented Apr 17, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 1edd8c1 into asyncapi:master Apr 17, 2023
@CyberHippo CyberHippo deleted the feature/release-assets-macos branch April 17, 2023 14:19
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@boyney123 boyney123 Awaiting requested review from boyney123

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberHippo @derberg @asyncapi-bot